Skip to content

Added ability to receive updates from sqlite3_update_hook#1267

Merged
daniellockyer merged 1 commit into
TryGhost:masterfrom
soukand:sqlite3_update_hook
Sep 13, 2022
Merged

Added ability to receive updates from sqlite3_update_hook#1267
daniellockyer merged 1 commit into
TryGhost:masterfrom
soukand:sqlite3_update_hook

Conversation

@soukand

@soukand soukand commented Dec 25, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Currently there are event insert/update/delete events defined on javascript side, but they are not working c++ side.
The code was already implemented in pull request #1174, but tests weren't added, so i decided to add them myself.

Error: update is not a valid configuration option
    at Database.addListener.Database.on (D:\dvp\study_stack\cloudfs\node_modules\sqlite3\lib\sqlite3.js:154:14)
    at SQLITE.on (D:\dvp\study_stack\cloudfs\libs\sql.js:74:15)
    at test.run (D:\dvp\study_stack\cloudfs\test.js:12:14)
    at <anonymous> Error: update is not a valid configuration option
    at Database.addListener.Database.on (D:\dvp\study_stack\cloudfs\node_modules\sqlite3\lib\sqlite3.js:154:14)
    at SQLITE.on (D:\dvp\study_stack\cloudfs\libs\sql.js:74:15)
    at test.run (D:\dvp\study_stack\cloudfs\test.js:12:14)
    at <anonymous>

@cuberoot

cuberoot commented Feb 20, 2020

Copy link
Copy Markdown

This would sure be useful. Any updates?

@cuberoot cuberoot mentioned this pull request Feb 20, 2020
Closed
@kewde kewde closed this Feb 20, 2020
@kewde kewde reopened this Feb 20, 2020
@kewde

kewde commented Feb 20, 2020

Copy link
Copy Markdown
Collaborator

Triggering CI again, this PR looks good.
Sorry for the delay.

@kewde kewde closed this Apr 19, 2020
@kewde kewde reopened this Apr 19, 2020
@tiendq

tiendq commented Sep 15, 2020

Copy link
Copy Markdown

Is it still open due to conflicts in database.cc?

kewde
kewde reviewed Jan 8, 2021
View reviewed changes
Comment thread src/database.cc Outdated
@justinmoon

justinmoon commented Mar 26, 2022

Copy link
Copy Markdown

This would be very useful for my project

@aceslick911

aceslick911 commented Apr 12, 2022

Copy link
Copy Markdown

+1 this :)

@daniellockyer

daniellockyer commented May 18, 2022

Copy link
Copy Markdown
Contributor

@soukand Would you be able to rebase the PR? 🙂

@daniellockyer daniellockyer mentioned this pull request May 21, 2022
Closed
@maxpert

maxpert commented Aug 18, 2022

Copy link
Copy Markdown

+1 this will be a game changer for what I am working on. Can we get this merged?

@volkanunsal

volkanunsal commented Sep 2, 2022

Copy link
Copy Markdown

We need this too. Are there any plans to merge it anytime soon?

@daniellockyer

daniellockyer commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

Hi all! 👋🏻 I am working on rebasing this myself but currently running into a situation where it causes the process to hang. I should have some more time next week to work on it 🙂

@daniellockyer daniellockyer mentioned this pull request Sep 8, 2022
Open
@daniellockyer daniellockyer changed the title added ability to receive updates from sqlite3_update_hook Added ability to receive updates from sqlite3_update_hook Sep 13, 2022
@soukand @daniellockyer
Added ability to receive updates from sqlite3_update_hook
946a3f6 
closes TryGhost#419

- this adds support for a `change` event which forwards events arising
  from `sqlite3_update_hook`
@daniellockyer daniellockyer merged commit 946a3f6 into TryGhost:master Sep 13, 2022
@daniellockyer

daniellockyer commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

Thanks for the patience everyone - this will be released shortly 🙂

@snyk-omar snyk-omar mentioned this pull request Oct 22, 2022
Open
@codebrainz

codebrainz commented Dec 26, 2022

Copy link
Copy Markdown

This seems to be missing from the documentation. Is there a more up-to-date API documentation than the Github wiki?

@antz-snyk antz-snyk mentioned this pull request Sep 30, 2023
Open
@jonathanchisnyk jonathanchisnyk mentioned this pull request Oct 28, 2023
Open
@cooldev-200 cooldev-200 mentioned this pull request May 20, 2024
Open
@fanibahar fanibahar mentioned this pull request May 21, 2024
Open
@WesleyR10 WesleyR10 mentioned this pull request Aug 21, 2024
Open
@slatersnyk slatersnyk mentioned this pull request Aug 22, 2024
Open
@cooldev-200 cooldev-200 mentioned this pull request Aug 22, 2024
Open
@rickybright rickybright mentioned this pull request Aug 29, 2024
Open
@NickyMartinez NickyMartinez mentioned this pull request Aug 30, 2024
Open
@fanibahar fanibahar mentioned this pull request Sep 6, 2024
Open
@irklva irklva mentioned this pull request Sep 7, 2024
Open
@akhnss akhnss mentioned this pull request Sep 10, 2024
Open
This was referenced Sep 13, 2024
Open
Open
Open
Open
Open
This was referenced Sep 20, 2024
Open
Open
@fanibahar fanibahar mentioned this pull request Sep 24, 2024
Open
@irklva irklva mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 24, 2024
Open
Open
Open
@phoebeyusnyk phoebeyusnyk mentioned this pull request Sep 29, 2024
Open
@MaximKing1 MaximKing1 mentioned this pull request Sep 29, 2024
Open
@tahmid198 tahmid198 mentioned this pull request Sep 30, 2024
Open
This was referenced Sep 30, 2024
Open
Open
Open
Open
Open
@ArijKouki ArijKouki mentioned this pull request Nov 11, 2024
Open
@nickvadala-snyk nickvadala-snyk mentioned this pull request Nov 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kewde kewde kewde left review comments

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@soukand @cuberoot @kewde @tiendq @justinmoon @aceslick911 @daniellockyer @maxpert @volkanunsal @codebrainz